Skip to content

Fix #4471 : Remove the discuss link from the UI #4472

Merged
RishabhJain2018 merged 1 commit intoCloud-CV:masterfrom
PrasadCodesML:bug/Remove_discuss_from_frontend
Mar 13, 2025
Merged

Fix #4471 : Remove the discuss link from the UI #4472
RishabhJain2018 merged 1 commit intoCloud-CV:masterfrom
PrasadCodesML:bug/Remove_discuss_from_frontend

Conversation

@PrasadCodesML
Copy link
Copy Markdown
Contributor

@PrasadCodesML PrasadCodesML commented Mar 13, 2025

This PR removes the "Discuss" link as mentioned in the issue #4471 from multiple header components in accordance with the project guidelines.

The changes include:

  1. Removing the "Discuss" link from main-header.html (mobile demo).
  2. Removing the "Discuss" link from sim-header.html.
  3. Removing the "Discuss" link from header-static.component.html.

These modifications ensure consistency across different headers while adhering to the design and functionality requirements.

Changes:

  1. main-header.html: Removed "Discuss" link.
  2. sim-header.html: Removed "Discuss" link.
  3. header-static.component.html: Removed "Discuss" link.

Screenshot :
image

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.30%. Comparing base (96968d6) to head (9fe0749).
Report is 1115 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4472      +/-   ##
==========================================
- Coverage   72.93%   69.30%   -3.63%     
==========================================
  Files          83       20      -63     
  Lines        5368     3574    -1794     
==========================================
- Hits         3915     2477    -1438     
+ Misses       1453     1097     -356     

see 64 files with indirect coverage changes

see 64 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 523e894...9fe0749. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@RishabhJain2018 RishabhJain2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM!

@RishabhJain2018 RishabhJain2018 merged commit 0309a5a into Cloud-CV:master Mar 13, 2025
2 of 3 checks passed
@PrasadCodesML PrasadCodesML deleted the bug/Remove_discuss_from_frontend branch March 13, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants