Skip to content

Fixes #4479 : Add tabs for all challenges page#4512

Merged
RishabhJain2018 merged 10 commits intoCloud-CV:masterfrom
lazyperson1020:tabs_for_challenges_updated
Mar 28, 2025
Merged

Fixes #4479 : Add tabs for all challenges page#4512
RishabhJain2018 merged 10 commits intoCloud-CV:masterfrom
lazyperson1020:tabs_for_challenges_updated

Conversation

@lazyperson1020
Copy link
Copy Markdown
Contributor

@lazyperson1020 lazyperson1020 commented Mar 25, 2025

425734631-0175cc17-523d-40d0-aa33-88709a46e385.mp4

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.28%. Comparing base (96968d6) to head (e0ddaf3).
Report is 1132 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4512      +/-   ##
==========================================
- Coverage   72.93%   69.28%   -3.65%     
==========================================
  Files          83       20      -63     
  Lines        5368     3572    -1796     
==========================================
- Hits         3915     2475    -1440     
+ Misses       1453     1097     -356
Files with missing lines Coverage Δ
frontend/src/js/controllers/challengeListCtrl.js 93.75% <100.00%> (-0.94%) ⬇️

... and 64 files with indirect coverage changes

Files with missing lines Coverage Δ
frontend/src/js/controllers/challengeListCtrl.js 93.75% <100.00%> (-0.94%) ⬇️

... and 64 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5fda03...e0ddaf3. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RishabhJain2018
Copy link
Copy Markdown
Member

RishabhJain2018 commented Mar 26, 2025 •
edited
Loading

Also, @lazyperson1020, please add tests so that codecov coverage remains the same.

@lazyperson1020
Copy link
Copy Markdown
Contributor Author

lazyperson1020 commented Mar 28, 2025

@RishabhJain2018 please check the codecov coverage.

@lazyperson1020
Copy link
Copy Markdown
Contributor Author

lazyperson1020 commented Mar 28, 2025

@RishabhJain2018 can we add chromium in the karma.conf.js to run frontend tests locally?

@RishabhJain2018
Copy link
Copy Markdown
Member

RishabhJain2018 commented Mar 28, 2025

@RishabhJain2018 can we add chromium in the karma.conf.js to run frontend tests locally?

Sure, please do it.

RishabhJain2018
RishabhJain2018 requested changes Mar 28, 2025
View reviewed changes
Comment thread frontend/src/js/controllers/challengeListCtrl.js Outdated
parameters.method = 'GET';

vm.getAllResults(parameters, vm.currentList, "noneCurrentChallenge");

Copy link
Copy Markdown
Member

@RishabhJain2018 RishabhJain2018 Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this line.

Copy link
Copy Markdown
Contributor Author

@lazyperson1020 lazyperson1020 Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@lazyperson1020
Copy link
Copy Markdown
Contributor Author

lazyperson1020 commented Mar 28, 2025

@RishabhJain2018 can we add chromium in the karma.conf.js to run frontend tests locally?

Sure, please do it.

Should I open a new PR for that?

@RishabhJain2018
Copy link
Copy Markdown
Member

RishabhJain2018 commented Mar 28, 2025

Yes!

RishabhJain2018
RishabhJain2018 approved these changes Mar 28, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@RishabhJain2018 RishabhJain2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@RishabhJain2018 RishabhJain2018 merged commit b1526c6 into Cloud-CV:master Mar 28, 2025
1 check passed
RishabhJain2018 added a commit that referenced this pull request Mar 2, 2026
@lazyperson1020 @Harshit28j @RishabhJain2018
Frontend fixes #4479: Add ongoing, past, future tabs on all challenge…
fd5654b 
…s page(#4512)

* Add tabs for challenges

* Optimized api call & added blank space in SCSS

* revert changes to js

* Add new line

* tests

* no change

* no change

* added tests

* changes

---------

Co-authored-by: hj <harshitjain0562@gmail.com>
Co-authored-by: Rishabh Jain <rishabhjain2018@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RishabhJain2018 RishabhJain2018 RishabhJain2018 approved these changes

Assignees

No one assigned

Labels

can-be-merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lazyperson1020 @RishabhJain2018 @Harshit28j