chore: unify document properties #1138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derklaro
added
v: 4.X
0utplay
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
At the moment there are different types of document properties. A DocProperty which can be appended and read from everything that implements DocPropertyHolder and a ServiceProperty which is exclusive to services. This means that we're basically maintaining two different document property apis, with the service property one having some more methods that were missing in the DocProperty api.
Modification
Removed the service property implementation completely and improved the doc property api to allow for everything that the current service property api allowed. Furthermore, the api was expanded and better integrated into the cloudnet system, to match the design of existing api classes.
Result
One general and now unified api to read and write doc properties.
Other context
Fixes #1072