feat: add object serializers for all kinds of time types #1285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derklaro
added
v: 4.X
0utplay
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There were multiple people in the past few days that tried to serialize a java.time class using the default object mapping system. At the moment this is not possible due to the lack of serializers for these types.
Modification
Add serializers for all java.time classes that are made to support the ISO-8601 standard. Other calendar systems (such as the Chinese one) are still not supported.
Result
Working with RPC and ISO-8601 java time types is now fully supported out of the box and no custom serializers are required anymore.