fix: command parsing and executing caused console dead lock #1565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0utplay
added
v: 4.X
derklaro
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Executing a lot of commands while e.g. services are starting (printing messages to the console) can lead to dead locks. This issue was probably introduced with the cloud 2.0 migration. Prior to cloud 2.0 the framework used to run suggestions on the caller thread. With cloud 2.0 a shared thread pool for suggestion, parsing and executing can be used. This then leads to dead locks.
Modification
Explicitly set the thread pool for parsing & executing only. Suggestions are processed on the caller thread (thus restoring cloud 1.0 behavior.
Result
No dead-locks of the console.