fix: provide fallback when server dies on bungeecord #1602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derklaro
added
v: 4.X
0utplay
approved these changes
Apr 1, 2025
GiantTreeLP
pushed a commit
to GiantTreeLP/CloudNet
that referenced
this pull request
Jun 7, 2025
…#1602) ### Motivation Currently, when a server unexpectedly closes the connection to the proxy, the player gets disconnected as CloudNet does not provide a fallback server. This is due to the fact that the ServerKickEvent is only called when the server sends a kick packet. In case the server goes down, BungeeCord tries to connect the player to the first priority (in our case a dummy `lobby` server as BungeeCord won't start without a priority) with the connection reason `SERVER_DOWN_REDIRECT`. We can catch this reason and provide a proper fallback in `ServerConnectEvent`. ### Modification Catch the `SERVER_DOWN_REDIRECT` reason in `ServerConnectEvent` and provide a proper fallback. If no fallback is available, disconnect the player with the new disconnection reason introduced in CloudNetService#1399. ### Result Players will be provided with a proper fallback in case of an unexpected connection close by the downstream service instead of being disconnected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, when a server unexpectedly closes the connection to the proxy, the player gets disconnected as CloudNet does not provide a fallback server. This is due to the fact that the ServerKickEvent is only called when the server sends a kick packet. In case the server goes down, BungeeCord tries to connect the player to the first priority (in our case a dummy
lobbyserver as BungeeCord won't start without a priority) with the connection reasonSERVER_DOWN_REDIRECT. We can catch this reason and provide a proper fallback inServerConnectEvent.Modification
Catch the
SERVER_DOWN_REDIRECTreason inServerConnectEventand provide a proper fallback. If no fallback is available, disconnect the player with the new disconnection reason introduced in #1399.Result
Players will be provided with a proper fallback in case of an unexpected connection close by the downstream service instead of being disconnected.