Skip to content

Conversation

@derklaro
Copy link
Member

Motivation

The console read thread currently enforces that all read lines must contain at least one non-space char. This leads to issues with handlers that actually want to accept blank input, e.g. in the module selection in the default setup.

Modification

Remove blank line check from console read thread, add blank check to some handlers.

Result

Blank input is now allowed by the console read thread, meaning that handlers can now properly handle blank input as they wish.

@derklaro derklaro added this to the 4.0.0-RC13 milestone Jun 16, 2025
@derklaro derklaro requested a review from 0utplay June 16, 2025 19:49
@derklaro derklaro self-assigned this Jun 16, 2025
@derklaro derklaro added v: 4.X This pull should be included in the 4.0 release in: node An issue/pull request releated to the node module code t: fix A pull request introducing a fix for a bug. labels Jun 16, 2025
@github-actions
Copy link

github-actions bot commented Jun 16, 2025

Test Results

 51 files  ±0   51 suites  ±0   1m 12s ⏱️ -8s
452 tests ±0  452 ✅ ±0  0 💤 ±0  0 ❌ ±0 
783 runs  ±0  783 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a83e84d. ± Comparison against base commit efe9f3a.

This pull request removes 35 and adds 35 tests. Note that renamed tests count towards both.
eu.cloudnetservice.driver.impl.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"insane":"!","this":"is","hello":"world"}}, PRETTY
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [23] 19:02:57.747096350
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [28] 19:02:57.747223577Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [29] 19:02:57.747246349Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [30] 19:02:57.747273750+05:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [31] 19:02:57.747293096-03:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [34] 2025-06-16T19:02:57.747414231
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [39] 2025-06-16T19:02:57.747553871Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [4] 2025-06-16T19:02:57.740145693Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [5] 2025-06-16T18:54:37.740149009Z
…
eu.cloudnetservice.driver.impl.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"this":"is","hello":"world","insane":"!"}}, PRETTY
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [23] 20:02:24.980652799
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [28] 20:02:24.980784385Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [29] 20:02:24.980808240Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [30] 20:02:24.980833547+05:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [31] 20:02:24.980851521-03:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [34] 2025-06-16T20:02:24.980988266
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [39] 2025-06-16T20:02:24.981137505Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [4] 2025-06-16T20:02:24.975929205Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [5] 2025-06-16T19:54:04.975933313Z
…

♻️ This comment has been updated with latest results.

0utplay
0utplay previously approved these changes Jun 16, 2025
@derklaro derklaro merged commit 25e9d0d into nightly Jun 18, 2025
5 checks passed
@derklaro derklaro deleted the console-drop-non-empty-line-check branch June 18, 2025 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: node An issue/pull request releated to the node module code t: fix A pull request introducing a fix for a bug. v: 4.X This pull should be included in the 4.0 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants