Skip to content

[FLOC-4507] Disallow installation of pycparser wheel file. #2915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wallrj wants to merge 2 commits into from
Closed

[FLOC-4507] Disallow installation of pycparser wheel file. #2915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d448383
Dissallow installation of pycparser wheel file. Workaround for https:…
wallrj Oct 3, 2016
20be050
Work around a lintian error
wallrj Oct 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions admin/packaging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,6 +679,11 @@ def __str__(self):
# Cryptography hazmat bindings
'package-installs-python-pycache-dir opt/flocker/lib/python2.7/site-packages/cryptography/hazmat/bindings/__pycache__/', # noqa

# Pycparser is installed from an sdist as of FLOC-4507 which seems to
# result in these cache directories.
'package-installs-python-pycache-dir opt/flocker/lib/python2.7/site-packages/pycparser/__pycache__/', # noqa
'package-installs-python-pycache-dir opt/flocker/lib/python2.7/site-packages/pycparser/ply/__pycache__/', # noqa

# files included by netaddr - we put the whole python we need in the
# flocker package, and lint complains. See:
# https://lintian.debian.org/tags/package-installs-ieee-data.html
Expand Down
4 changes: 4 additions & 0 deletions dev-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# Do not install the broken pycparser-2.14-py2.py3-none-any.whl
# Workaround for:
# https://github.com/eliben/pycparser/issues/148
--no-binary pycparser
# Install everything required for local development.
--requirement requirements/all.txt
--editable .
4 changes: 4 additions & 0 deletions requirements/constraints.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# Do not install the broken pycparser-2.14-py2.py3-none-any.whl
# Workaround for:
# https://github.com/eliben/pycparser/issues/148
--no-binary pycparser
# awscli has very specific colarama requirements while pylint doesn't
colorama<=0.3.3,>=0.2.5
# docker-py requirement since https://github.com/docker/docker-py/pull/1127
Expand Down