Fix: ping: Avoid temporary files for fping check - #1128
Merged
Conversation
In a7373f9, bash heredocs still create a temporary file in the background. This commit avoids temporary files in a simple compromise way when parsing the output of fping.
|
This seems like a good approach. The intermingled stdout+stderr may be difficult to read, but it's an unlikely situation anyway, and would probably indicate the RA needs updating. |
Contributor
|
Bonus point for addressing both items in #1117 (comment) at once (IIUIC) :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a7373f9, bash heredocs still create a temporary file in the
background. This commit avoids temporary files in a simple compromise
way when parsing the output of fping.