refactor: remove hardcoded GPU device type and use configurable attributes#22
Merged
ttsuuubasa merged 1 commit intoCoHDI:mainfrom Dec 17, 2025
Merged
refactor: remove hardcoded GPU device type and use configurable attributes#22ttsuuubasa merged 1 commit intoCoHDI:mainfrom
ttsuuubasa merged 1 commit intoCoHDI:mainfrom
Conversation
…butes
- Change device naming pattern from "{k8sDeviceName}-gpu{index}" to "{k8sDeviceName}-{index}"
- Remove GpuDeviceType constant that was hardcoded as "gpu"
- Use dynamic DRA attributes from device configuration instead of fixed "type: gpu"
- Update corresponding test expectations for new device naming convention
Signed-off-by: Tsubasa Watanabe <w.tsubasa@fujitsu.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors device naming and attribute handling in CDIManager to improve flexibility and remove hardcoded GPU-specific logic.
Changes
Device Naming
Changed pattern from "{k8sDeviceName}-gpu{index}" to "{k8sDeviceName}-{index}" for consistency and to remove GPU-specific suffix.
Attributes Handling
Removed GpuDeviceType constant that was hardcoded as "gpu".
Attributes are now initialized as an empty map and populated dynamically from device configuration instead of using fixed "type: gpu".
Tests
Updated test expectations to reflect the new device naming convention.
Motivation
Improves naming consistency across different device types.
Makes attribute handling more generic and future-proof for non-GPU devices.
Reduces coupling between device generation logic and GPU-specific assumptions.
Impact
Breaking Change: Any code or scripts relying on the old naming pattern (-gpu{index}) must be updated.
Consumers expecting "type: gpu" in attributes should now set this explicitly if required.