Skip to content
This repository was archived by the owner on Nov 3, 2020. It is now read-only.

Drag & Drop functionality on Home Window#184

Merged
orta merged 8 commits intoCocoaPods:masterfrom
wrutkowski:drag-n-drop
Jan 16, 2016
Merged

Drag & Drop functionality on Home Window#184
orta merged 8 commits intoCocoaPods:masterfrom
wrutkowski:drag-n-drop

Conversation

@wrutkowski
Copy link
Copy Markdown
Contributor

Only Podfile can be dropped. Possible to drop multiple different files at once, but only Podfile will be opened.

@wrutkowski
Copy link
Copy Markdown
Contributor Author

As per #181 and #180 task 4.

Conflicts:
	app/CocoaPods/CPRecentDocumentsController.h
	app/CocoaPods/CPRecentDocumentsController.m
Comment thread app/CocoaPods/CPHomeWindowController.m Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright this looks good, any chance you can create a function that returns the first Podfile in a dragging pasteboard? then it could be used in both entered, and perform drag operation, this significantly reduces the amount of indentation for these methods and lets them talk about the what rather than the how.

@orta
Copy link
Copy Markdown
Member

orta commented Jan 16, 2016

👍

@orta
Copy link
Copy Markdown
Member

orta commented Jan 16, 2016

damn, sorry to keep forcing you to rebase @wrutkowski :-/

@wrutkowski
Copy link
Copy Markdown
Contributor Author

@orta Ready to merge :)

orta added a commit that referenced this pull request Jan 16, 2016
Drag & Drop functionality on Home Window
@orta orta merged commit a212670 into CocoaPods:master Jan 16, 2016
@orta
Copy link
Copy Markdown
Member

orta commented Jan 16, 2016

Ace, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants