feat: dump node process information when running#77
Open
GuillaumeLagrange wants to merge 1 commit intomainfrom
Open
feat: dump node process information when running#77GuillaumeLagrange wants to merge 1 commit intomainfrom
GuillaumeLagrange wants to merge 1 commit intomainfrom
Conversation
Merging this PR will degrade performance by 39.05%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Memory | wait 1ms |
7 B | 10 B | -30% |
| ❌ | Memory | short body |
480 B | 608 B | -21.05% |
| ❌ | Memory | short body |
480 B | 608 B | -21.05% |
| ❌ | Memory | long body |
960 B | 1,088 B | -11.76% |
| ❌ | Memory | wait 500ms |
39.1 KB | 64.1 KB | -39.05% |
| ⚡ | WallTime | short body |
2.1 µs | 1.8 µs | +17.45% |
| ❌ | Simulation | wait 500ms |
8.7 ms | 13.1 ms | -34.17% |
| ❌ | Simulation | wait 1sec |
19.2 ms | 24 ms | -19.87% |
| ❌ | Simulation | wait 1sec |
21.3 ms | 23.8 ms | -10.58% |
| ❌ | Simulation | wait 500ms |
10.5 ms | 13.2 ms | -20.72% |
Comparing cod-2036-node-in-profiling-cli (c157255) with main (4f97cbe)
GuillaumeLagrange
force-pushed
the
cod-2036-node-in-profiling-cli
branch
from
7c01712 to
37a9e74
Compare
GuillaumeLagrange
force-pushed
the
cod-2036-node-in-profiling-cli
branch
2 times, most recently
from
46124a6 to
756b1e2
Compare
adriencaccia
approved these changes
Apr 1, 2026
packages/core/src/index.ts
Outdated
| const hooks = native_core.InstrumentHooks; | ||
| hooks.setEnvironment("nodejs", "version", process.versions.node); | ||
| hooks.setEnvironment("nodejs", "v8", process.versions.v8); | ||
| hooks.setEnvironment("nodejs", "arch", process.arch); |
Member
There was a problem hiding this comment.
Remove it since it is already collected
GuillaumeLagrange
force-pushed
the
cod-2036-node-in-profiling-cli
branch
from
756b1e2 to
c157255
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.