This repository was archived by the owner on Jun 25, 2020. It is now read-only.
Add support for category in page permalinks#189
Merged
Conversation
Contributor
|
I'm good with the "show only a specific category" but why the limit to 3? Also there is no reference to :category1 and other in the jekyll doc, do you want to have a "categoty1/category2" url instead of the current "category1-category2"? |
Contributor
Author
|
Looks like I might have read that doco page wrong but our usage is to only use the first category in the url so the |
Contributor
Author
|
Also, with making it generic. I tried only loading it based on the number of categories on the page but if there are no categories it would not remove the |
Contributor
|
I'll try to provide a generic solution, but if I fail I'll merge your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use categories in our permalinks because reasons. 🎱
Here are the docs: http://jekyllrb.com/docs/permalinks/