feat: refactoring

src/main/java/com/codedead/opal/controller/MainWindowController.java

@@ -425,7 +425,7 @@ private void settingsAction() {
             logger.info("Showing the SettingsWindow");
             primaryStage.show();
             primaryStage.setWidth(450);
-            primaryStage.setHeight(320);
+            primaryStage.setHeight(350);
         } catch (final IOException ex) {
             logger.error("Unable to open the SettingsWindow", ex);
             FxUtils.showErrorAlert(translationBundle.getString("SettingsWindowError"), ex.toString(), getClass().getResourceAsStream(SharedVariables.ICON_URL));
@@ -510,7 +510,7 @@ private void aboutAction() {
             logger.info("Showing the AboutWindow");
             primaryStage.show();
             primaryStage.setWidth(450);
-            primaryStage.setHeight(250);
+            primaryStage.setHeight(280);
         } catch (final IOException ex) {
             logger.error("Unable to open the AboutWindow", ex);
             FxUtils.showErrorAlert(translationBundle.getString("AboutWindowError"), ex.toString(), getClass().getResourceAsStream(SharedVariables.ICON_URL));
@@ -549,7 +549,7 @@ public void fired() {
                         String line;
                         while ((line = reader.readLine()) != null) {
                             builder.append(line);
-                            builder.append(System.getProperty("line.separator"));
+                            builder.append(System.lineSeparator());
                         }
                         final String result = builder.toString();
                         logger.info("Shutdown command result: {}", result);
@@ -606,7 +606,7 @@ private void onDragDropped(final DragEvent dragEvent) {
         boolean success = false;
 
         if (db.hasFiles()) {
-            openSoundPreset(db.getFiles().get(0).getAbsolutePath());
+            openSoundPreset(db.getFiles().getFirst().getAbsolutePath());
             success = true;
         }
 

src/main/java/com/codedead/opal/controller/UpdateController.java

@@ -126,17 +126,18 @@ private int versionCompare(final String v1, final String v2) {
     public List<PlatformUpdate> getUpdates() throws IOException, InterruptedException, InvalidHttpResponseCodeException {
         logger.info("Attempting to retrieve List of PlatformUpdate objects from {}", getUpdateUrl());
 
-        final HttpClient client = HttpClient.newHttpClient();
-        final HttpRequest request = HttpRequest.newBuilder()
-                .uri(URI.create(getUpdateUrl()))
-                .build();
+        try (final HttpClient client = HttpClient.newHttpClient()) {
+            final HttpRequest request = HttpRequest.newBuilder()
+                    .uri(URI.create(getUpdateUrl()))
+                    .build();
 
-        final HttpResponse<String> response = client.send(request, HttpResponse.BodyHandlers.ofString());
+            final HttpResponse<String> response = client.send(request, HttpResponse.BodyHandlers.ofString());
 
-        if (response.statusCode() == 200)
-            return Arrays.asList(objectMapper.readValue(response.body(), PlatformUpdate[].class));
+            if (response.statusCode() == 200)
+                return Arrays.asList(objectMapper.readValue(response.body(), PlatformUpdate[].class));
 
-        throw new InvalidHttpResponseCodeException(String.format("Invalid HTTP response code (%s)", response.statusCode()));
+            throw new InvalidHttpResponseCodeException(String.format("Invalid HTTP response code (%s)", response.statusCode()));
+        }
     }
 
     /**

src/main/java/com/codedead/opal/utils/FxUtils.java

@@ -30,13 +30,10 @@ public static void showInformationAlert(final String content, final InputStream
             throw new NullPointerException("Content cannot be null!");
 
         final Alert alert = new Alert(Alert.AlertType.INFORMATION, content, ButtonType.OK);
-        alert.setResizable(true);
-
         final Stage stage = (Stage) alert.getDialogPane().getScene().getWindow();
 
-        if (imageStream != null) {
+        if (imageStream != null)
             stage.getIcons().add(new Image(imageStream));
-        }
 
         alert.showAndWait();
     }
@@ -50,13 +47,10 @@ public static void showInformationAlert(final String content, final InputStream
      */
     public static boolean showConfirmationAlert(final String content, final InputStream imageStream) {
         final Alert alert = new Alert(Alert.AlertType.CONFIRMATION, content, ButtonType.YES, ButtonType.NO);
-        alert.setResizable(true);
-
         final Stage stage = (Stage) alert.getDialogPane().getScene().getWindow();
 
-        if (imageStream != null) {
+        if (imageStream != null)
             stage.getIcons().add(new Image(imageStream));
-        }
 
         alert.showAndWait();
 
@@ -110,9 +104,7 @@ private static Alert getErrorAlert(final String content) {
         GridPane.setHgrow(textArea, Priority.ALWAYS);
 
         expContent.add(textArea, 0, 0);
-
         alert.getDialogPane().setExpandableContent(expContent);
-        alert.setResizable(true);
 
         return alert;
     }

src/main/resources/windows/AboutWindow.fxml

@@ -10,7 +10,7 @@
           xmlns:fx="http://javafx.com/fxml"
           alignment="CENTER"
           fx:controller="com.codedead.opal.controller.AboutWindowController"
-          prefHeight="250.0" prefWidth="450.0">
+          prefHeight="280.0" prefWidth="450.0">
 
     <rowConstraints>
         <RowConstraints/>

src/main/resources/windows/SettingsWindow.fxml

@@ -19,7 +19,7 @@
 <GridPane xmlns="http://javafx.com/javafx"
           xmlns:fx="http://javafx.com/fxml"
           fx:controller="com.codedead.opal.controller.SettingsWindowController"
-          prefHeight="320.0" prefWidth="450.0">
+          prefHeight="350.0" prefWidth="450.0">
 
     <rowConstraints>
         <RowConstraints vgrow="ALWAYS"/>