Skip to content

Conversation

@Procaseycash
Copy link
Contributor

@Procaseycash Procaseycash commented Nov 8, 2022

Ehancement

  • Remove redundant from hash function as hash + 0 will give the same result and likewise special chars is also hash + 0
  • Remove code duplication to aid management and follow SOLID rules
  • Correct the test case return type

Test

  • All test cases were ran and successful

@CodePapi CodePapi self-requested a review November 8, 2022 17:08
Copy link
Owner

@CodePapi CodePapi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,
Test cases in order

@CodePapi CodePapi merged commit d62010a into CodePapi:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants