Day one Kotlin for Hacktoberfest#358
Merged
aaditkamat merged 2 commits intoCodeToExpress:masterfrom Oct 15, 2020
Merged
Conversation
Contributor
Author
|
Here is my new pull request. Sorry about the last one without pulling from this repo first :( |
aaditkamat
reviewed
Oct 15, 2020
| } | ||
| } | ||
|
|
||
| fizzBuzz((1..15).toList()) |
There was a problem hiding this comment.
If I'm not wrong, a top level declaration is required.
Suggested change
| fizzBuzz((1..15).toList()) | |
| fun main() { | |
| fizzBuzz((1..15).toList()) | |
| } |
Contributor
Author
There was a problem hiding this comment.
For Kotlin script file(.kts) stand alone functions work without the associated main function. I can make the change though.
There was a problem hiding this comment.
In that case you can leave it as it is.
aaditkamat
reviewed
Oct 15, 2020
| } | ||
| } | ||
|
|
||
| fizzBuzz((1..15).toList()) |
There was a problem hiding this comment.
Should reflect the change made in the source code file
aaditkamat
suggested changes
Oct 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please make sure you have done the following:
/Day<n>/<Language>//Day <n>/all-contributors-cli