Make local testing use django 3.#242
Merged
BlayeeR merged 1 commit intoJun 25, 2024
Merged
Conversation
Local testing uses a different package install process then the CI. To prevent us running postgres 12 default while local testing bu use 11 instead we must also use django 3. To enable this we in the setup.py which is used for local testing require a django 3 version instead of a django 3 or 4 version. Since django 4 is only postgres 12+ compatible.
BlayeeR
approved these changes
Jun 25, 2024
Contributor
BlayeeR
left a comment
BlayeeR
left a comment
There was a problem hiding this comment.
LGTM, worth noting that github workflow is testing for both django 3 and django 4 respectively, so this change only affects local dev environment
BBooijLiewes
added a commit
that referenced
this pull request
Jun 25, 2024
Local testing uses a different package install process then the CI. To prevent us running postgres 12 default while local testing bu use 11 instead we must also use django 3. To enable this we in the setup.py which is used for local testing require a django 3 version instead of a django 3 or 4 version. Since django 4 is only postgres 12+ compatible. Co-authored-by: Bob Booij-Liewes <bob@codeyellow.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local testing uses a different package install process then the CI. To prevent us running postgres 12 default while local testing bu use 11 instead we must also use django 3.
To enable this we in the setup.py which is used for local testing require a django 3 version instead of a django 3 or 4 version. Since django 4 is only postgres 12+ compatible.