Skip to content
This repository was archived by the owner on Oct 26, 2020. It is now read-only.

Davinder Singh V1 - First draft created#25

Open
davappler wants to merge 1 commit intoCodeYourFuture:masterfrom
davappler:Davinder-HTML-CSS-HW-week-1
Open

Davinder Singh V1 - First draft created#25
davappler wants to merge 1 commit intoCodeYourFuture:masterfrom
davappler:Davinder-HTML-CSS-HW-week-1

Conversation

@davappler
Copy link
Copy Markdown

@davappler davappler commented May 9, 2020

Hello

I created the website according to the tasks provided. I have edited the index.html and style.css files and have added 2 new folders called images and slideshow for the photos used on the website.

Thankyou

Copy link
Copy Markdown

@Shukriy Shukriy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done Davinder for completing your first HTML/CSS homework. You have completed all the tasks in this project very well. You have even went beyond and added a nice functionality of image slide show, very impressed with that.

The only thing that I would recommend you to have regular commits with description of what you have been working on exactly. This means anytime you added tags, functionality, section or even fixed an error. It will help you to remember what you have changed in each version but also when other people review your code on GitHub then can have a better understand as well.

Overall, great work. Continue going beyond and looking forward seeing your work.

@davappler
Copy link
Copy Markdown
Author

Hey Shukri , thank you so much.
I will try to keep this in mind and will try to do regular commits.
Thank-you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants