This repository was archived by the owner on Oct 26, 2020. It is now read-only.
Hadiyah : HTML-CSS Homework wk1#26
Open
HadiyahL wants to merge 9 commits intoCodeYourFuture:masterfrom
Open
Conversation
Shukriy
approved these changes
May 18, 2020
Shukriy
left a comment
Shukriy
left a comment
There was a problem hiding this comment.
Well done Hadiyah for completing your first HTML/CSS homework. You have a great layout with simple color scheme which I like. It seems you have ticked off all the tasks and implemented well.
I am not sure whether this is the case for you but for some reason the images are not loading for me. I would place the image folder in the week1 website folder (otherwise you will have to change the path of the image) and remove the first forward slash (src="images/bench.jpg"
) for all images.
In regards to your commits, I would try to be more descriptive so that anyone looking through your GitHub knows exactly what you have worked on.
Overall, well done. Keep the good work and looking forward to your next project,
I moved the images folder into week1 website folder and removed unused images from the folder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pull request for my completed assignment.