Osagie/week1#31
Conversation
|
No issues |
|
Updating my work |
Added Flukeout screenshot
|
Attached image file |
|
Updating master repo |
|
Latest work following some merging |
| <div class="social"> | ||
| <ul> | ||
| <li> <i class="fa fa-facebook"></i> </li> | ||
| <li> <i class="fa fa fa-twitter"></i> </li> |
There was a problem hiding this comment.
Corrected it. I have made I believe you meant only the one on facebook link. I initially tried fa fa (twice) for all of them and then fa fa fa (thrice). I got same result. Not quite sure why???
| <img class="solo" src="https://i.ytimg.com/vi/4HpAujV1OOc/maxresdefault.jpg" alt="Sololearn logo"> | ||
| </article> | ||
| </section> | ||
| <section class="drop"> |
There was a problem hiding this comment.
Similarly with these class names, if they identify a single element, they should be IDs instead
| <li>HTML using FreeCodeCamp</li> | ||
| <li>CSS using FreeCodeCamp</li> | ||
| </ul> | ||
| <a class="weblink" href="https://www.freecodecamp.org/osagie">This is FreeCodeCamp link</a> |
There was a problem hiding this comment.
This is a correct use of a class! My only issue with this is that you have 2 classes, 'link' and 'weblink' which mean the same thing. Perhaps 'internal-link' and 'external-link' instead?
There was a problem hiding this comment.
I have changed the link for the navigation to internal-link and the other ones on the main containers as external-link classes and styled according on the CSS file.
| } | ||
|
|
||
| /*group class code for logos*/ | ||
| .solo, .codepen, .codeorg, .capgemini { |
There was a problem hiding this comment.
If the same CSS applies to 4 different classes, consider using a single class instead. See also line 112
There was a problem hiding this comment.
I have now assigned a class="course" to all of them and styled as [.course].
| } | ||
|
|
||
| /*targets only the Pre-Bootcamp menu link*/ | ||
| a[href*="Intro"] { |
There was a problem hiding this comment.
I've literally never seen this done before! That's... probably not a good sign, though. IDs work better for this kind of singling out, or child selection can also work if specified correctly.
There was a problem hiding this comment.
Corrected now. Used id selector [#active].
2 participants
Homework week 1