Skip to content
This repository was archived by the owner on Feb 27, 2023. It is now read-only.

Completed Week 1 and 2 exercises#54

Open
A-Meri wants to merge 23 commits intoCodeYourFuture:masterfrom
A-Meri:master
Open

Completed Week 1 and 2 exercises#54
A-Meri wants to merge 23 commits intoCodeYourFuture:masterfrom
A-Meri:master

Conversation

@A-Meri
Copy link
Copy Markdown

@A-Meri A-Meri commented Feb 17, 2019

No description provided.

Copy link
Copy Markdown
Member

@tekul tekul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good work, Ahmed. your code all looks fine. Just be careful about committing (use git status and git diff) to make sure you only add the files and changes you want in a commit.

Comment thread Project 101/npm-debug.log
10 error missing script: index.html
11 error If you need help, you may report this error at:
11 error <https://github.com/npm/npm/issues>
12 verbose exit [ 1, true ]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you don't add unwanted files like this npm log by mistake (this is why using git add . is a bad idea).

Comment thread Project 101/index.html
</body>

<footer></footer>
</html>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be in the html-css-git-exercises repository?


.messages .message__content {
line-height: 3;
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice comments 🙂 .

Gluten Free
</label>
</fieldset>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checkboxes should usually have a name attribute and also a value if the form is intended to be submitted to a server.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants