Skip to content
This repository was archived by the owner on Feb 27, 2023. It is now read-only.

completed exercises week-3#56

Open
havvarslan wants to merge 21 commits intoCodeYourFuture:masterfrom
havvarslan:master
Open

completed exercises week-3#56
havvarslan wants to merge 21 commits intoCodeYourFuture:masterfrom
havvarslan:master

Conversation

@havvarslan
Copy link
Copy Markdown

No description provided.

@tekul
Copy link
Copy Markdown
Member

tekul commented Feb 18, 2019

Hi @havvarslan. This looks pretty good :). For exercise 8 ("advanced selectors"), the idea is that you use child selectors and other more complex CSS selectors.

So, for example, rather than defining a style for p which would affect all paragraphs within the page, you should use a child selector to specify the single paragraph which should have white text.

@tekul
Copy link
Copy Markdown
Member

tekul commented Feb 18, 2019

There is also a bit of an issue with the "semantic HTML" part of exercise 29 (
2ff1717). You should perhaps re-read the original notes on that. You have replaced h1 with header for example. And what should typically go inside the nav tag?

Copy link
Copy Markdown
Member

@tekul tekul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work Havva! Keep it up. It looks like you understand most of the concepts we've seen so far. Watch out for cut and paste errors, revise the "semantic html" stuff and ask if you have any questions there. Also try to be methodical about committing work to git as you complete it. This makes it easier to keep track of what you're working on and also to review your previous work if you want to quickly find what you did for a past exercise.

<!-- Add a label here -->
<input type="text" name="q" />
<label for="search">Search on Google</label>
<input id="search" type="text" name="uid" />
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the field seems to have changed here from q to uid?

<br />
<label>
<input type="checkbox" name="dietary" value="en" />
Gluten Free
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value attributes here should match the different dietary selections. It looks like you copied them from the language example 🙂 .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants