Merged
Conversation
talyssonoc
requested changes
Feb 13, 2017
app/views/admin/users/index.html.erb
Outdated
Member
|
How do you access this page? I am not finding the menu item. |
fix edit buttons & add translation add locales to edit
marcosjr182
force-pushed
the
admin_users_redesign
branch
from
b615972 to
964591d
Compare
Contributor
Author
|
I have added a new button on |
marcosjr182
force-pushed
the
admin_users_redesign
branch
from
964591d to
a5822d1
Compare
talyssonoc
approved these changes
Feb 14, 2017
|
LGTM |
daniloisr
approved these changes
Feb 14, 2017
app/views/admin/users/index.html.erb
Outdated
There was a problem hiding this comment.
Talvez seja interessante extrair essa lógica para um presenter.
💅
Contributor
Author
There was a problem hiding this comment.
Agreed! =) I am will be moving it to a presenter on a separate PR to refactor a couple views.
marcosjr182
force-pushed
the
admin_users_redesign
branch
from
a5822d1 to
75847cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add a couple pages under
admin_userroutes redesign, which were missing from #62.admin_userroutes, which were missing from Mimic the new Pivotal Tracker look and feel #62.edit_teamso the users can access those pagesBefore
After