code-review-1#1
Open
HerrNiklasRaab wants to merge 1 commit into
Open
Conversation
HerrNiklasRaab
commented
Nov 11, 2020
Comment on lines
+52
to
72
| public class FrequentRenterPoints | ||
| { | ||
| public Rental Rental { get; set; } | ||
| public FrequentRenterPoints(Rental rental) | ||
| { | ||
| this.Rental = rental; | ||
| } | ||
|
|
||
| public Movie getMovie () { | ||
| return movie; | ||
| public int GetEarnedPoints() | ||
| { | ||
| if (EligibleForBonusPoints()) { return 2; } | ||
| return 1; | ||
| } | ||
|
|
||
| public int getDaysRented () { | ||
| return daysRented; | ||
| public bool EligibleForBonusPoints() | ||
| { | ||
| return Rental.getMovie().GetMovieRentalStrategy() is MovieNewReleaseRentalStrategy && | ||
| Rental.getDaysRented() > 1; | ||
| } | ||
|
|
||
| } |
Contributor
Author
There was a problem hiding this comment.
Feature Envy
Comment on lines
+35
to
+36
| WriteOwedAmountTo(statementElements.Sum(statementElmenet => statementElmenet.Amount), statementBuilder); | ||
| WriteFrequentRenterPointstTo(statementElements.Sum(statementElmenet => statementElmenet.FrequentRenterPoints), statementBuilder); |
Contributor
Author
There was a problem hiding this comment.
Single Responsibility
Should have been two methods: TotalAmount(), TotalFrequentRenterPoints()
Comment on lines
+25
to
+33
| var statementElements = rentals.Select(rental => | ||
| { | ||
| return new | ||
| { | ||
| Amount = rental.GetAmount(), | ||
| FrequentRenterPoints = new FrequentRenterPoints(rental).GetEarnedPoints(), | ||
| Description = $"\t{rental.getMovie().getTitle()}\t{rental.GetAmount()}" | ||
| }; | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
Useless, you could also have iterated directly over rental.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.