Skip to content

Follow some best practices #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abhishek01039 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Follow some best practices #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions refactoring-movie/movie.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
class Customer {
String name;
List<Rental> rentals = List<Rental>();

Customer(this.name);

String name;
List<Rental> rentals = <Rental>[];

void addRental(Rental rental) {
rentals.add(rental);
}
Expand All @@ -26,10 +26,10 @@ class Customer {
}

class Rental {
Movie movie;
int daysRented;
const Rental(this.movie, this.daysRented);

Rental(this.movie, this.daysRented);
final Movie movie;
final int daysRented;

double price() => movie.price(daysRented);

Expand All @@ -39,18 +39,18 @@ class Rental {
}

abstract class Movie {
final String title;
const Movie(this.title);

Movie(this.title);
final String title;

double price(int days);
int frequentRenterPoints(int days);
}

class NewReleaseMovie implements Movie {
final String title;
const NewReleaseMovie(this.title);

NewReleaseMovie(this.title);
final String title;

@override
double price(int days) => days * 3.0;
Expand All @@ -60,9 +60,9 @@ class NewReleaseMovie implements Movie {
}

class RegularMovie implements Movie {
final String title;
const RegularMovie(this.title);

RegularMovie(this.title);
final String title;

@override
double price(int days) => days > 2 ? (days - 2) * 1.5 : 2.0;
Expand All @@ -72,9 +72,9 @@ class RegularMovie implements Movie {
}

class ChildrenMovie implements Movie {
final String title;
const ChildrenMovie(this.title);

ChildrenMovie(this.title);
final String title;

@override
double price(int days) {
Expand Down