Skip to content

Joint Venture of #109 and #120#124

Merged
freak4pc merged 3 commits into
CombineCommunity:mainfrom
mRs-:main
Apr 22, 2022
Merged

Joint Venture of #109 and #120#124
freak4pc merged 3 commits into
CombineCommunity:mainfrom
mRs-:main

Conversation

@mRs-
Copy link
Copy Markdown

@mRs- mRs- commented Apr 21, 2022

I've cherry picked both solution in one PR so that we can get this merged ASAP 😀

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2022

Codecov Report

Merging #124 (cb87e62) into main (ee629db) will decrease coverage by 0.02%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
- Coverage   95.35%   95.32%   -0.03%     
==========================================
  Files          66       66              
  Lines        3551     3576      +25     
==========================================
+ Hits         3386     3409      +23     
- Misses        165      167       +2     
Impacted Files Coverage Δ
Tests/ShareReplayTests.swift 96.70% <91.30%> (-0.79%) ⬇️
Sources/Subjects/ReplaySubject.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee629db...cb87e62. Read the comment docs.

@freak4pc freak4pc merged commit 98ff2ad into CombineCommunity:main Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants