Cross-build for Native - #427
Merged
Merged
Conversation
…to feature/native
…to feature/native
Member
|
How long until we could have a milestone build of idna4s? If soon, I'd rather avoid the temporary import of icu4j. |
Contributor
Author
|
Cool, I've just pushed a commit that replaces the icu4j Punycode port with what's currently on If we're okay to swallow any bincompat breaks / version bumps on Native while that finalizes, I think this is a very reasonable way forward. |
Closed
armanbilge
marked this pull request as ready for review
September 14, 2022 23:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening for CI and pre-review.
As a hold-over until idna4s releases, I inlined a package-private Scala port of icu4j to roughly implement IDNA2008 for Scala Native. It is not a UTS46 implementation. But it does pass the test suite of the Punycode.js module currently used for Scala.js, and it doesn't require any dependencies.