-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Expand styling and customization docs #3933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,15 +31,13 @@ const root = css` | |
| --rdg-checkbox-focus-color: hsl(207deg 100% 69%); | ||
|
|
||
| &.rdg-dark { | ||
| --rdg-color-scheme: dark; | ||
| color-scheme: dark; | ||
| } | ||
|
|
||
| &.rdg-light { | ||
| --rdg-color-scheme: light; | ||
| color-scheme: light; | ||
| } | ||
|
|
||
| color-scheme: var(--rdg-color-scheme, light dark); | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What do you think about this changes?
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this makes sense. |
||
|
|
||
| &:dir(rtl) { | ||
| --rdg-cell-frozen-box-shadow: -2px 0 5px -2px rgba(136, 136, 136, 0.3); | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can make it a static function to promote best practices
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, and reworded the perf note.