Skip to content

CORE-329 feat: add Save 3D (Advanced) node family#14701

Merged
alexisrolland merged 6 commits into
masterfrom
CORE-329-save-3d-advanced
Jul 10, 2026
Merged

CORE-329 feat: add Save 3D (Advanced) node family#14701
alexisrolland merged 6 commits into
masterfrom
CORE-329-save-3d-advanced

Conversation

@jtydhr88

@jtydhr88 jtydhr88 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Add Save3DAdvanced, SaveGaussianSplat, and SavePointCloud as the save-side counterparts to the advanced preview nodes (Preview 3D (Advanced), Preview Splat, Preview Point Cloud).

Each mirrors its preview node's input/output shape and display name, and saves the File3D to the output directory under filename_prefix (preserving the original format), then emits PreviewUI3DAdvanced for the viewport.

FE change - Comfy-Org/ComfyUI_frontend#13330

Screenshot
Save 3D (Advanced)
image

Save Splat
image

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

This change adds advanced 3D save support in comfy_extras/nodes_save_3d.py. It adds shared helpers for saving Types.File3D outputs and building a preview node response with camera and model metadata. It also introduces Save3DAdvanced, SaveGaussianSplat, and SavePointCloud, and registers them in the 3D save extension.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding a new Save 3D advanced node family.
Description check ✅ Passed The description matches the changes by describing the new save-side 3D nodes and their preview counterparts.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@comfy_extras/nodes_save_3d.py`:
- Around line 409-420: The 3D save path helper is not forwarding the node’s
actual dimensions, so `%width%` and `%height%` in filename_prefix resolve to 0.
Update `_save_file3d_to_output` and its caller from `execute_save_3d_advanced`
to pass the real width/height values into `folder_paths.get_save_image_path`,
matching the pattern used by other Save* nodes so templated filenames use the
node inputs instead of defaults.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d9338cc5-1901-4422-b813-4dcd2a719ee1

📥 Commits

Reviewing files that changed from the base of the PR and between 50e5270 and eea3502.

📒 Files selected for processing (1)
  • comfy_extras/nodes_save_3d.py

Comment thread comfy_extras/nodes_save_3d.py
Comment thread comfy_extras/nodes_save_3d.py Outdated
Comment thread comfy_extras/nodes_save_3d.py Outdated
@jtydhr88
jtydhr88 force-pushed the CORE-329-save-3d-advanced branch from eea3502 to 78d9bfd Compare July 1, 2026 12:18
@alexisrolland
alexisrolland self-requested a review July 3, 2026 07:16
@jtydhr88
jtydhr88 force-pushed the CORE-329-save-3d-advanced branch from d17642f to 747d212 Compare July 4, 2026 02:09
@jtydhr88
jtydhr88 force-pushed the CORE-329-save-3d-advanced branch from 747d212 to 74f9907 Compare July 9, 2026 01:52
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jul 9, 2026
alexisrolland
alexisrolland previously approved these changes Jul 9, 2026
@alexisrolland
alexisrolland self-requested a review July 9, 2026 08:40
Comment thread comfy_extras/nodes_save_3d.py Outdated
@alexisrolland
alexisrolland dismissed stale reviews from coderabbitai[bot] and themself via f1d542e July 9, 2026 08:52
@alexisrolland
alexisrolland self-requested a review July 10, 2026 19:53
@alexisrolland
alexisrolland merged commit 328144c into master Jul 10, 2026
16 of 17 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 10, 2026
@jtydhr88
jtydhr88 deleted the CORE-329-save-3d-advanced branch July 10, 2026 20:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants