CORE-329 feat: add Save 3D (Advanced) node family#14701
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis change adds advanced 3D save support in 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@comfy_extras/nodes_save_3d.py`:
- Around line 409-420: The 3D save path helper is not forwarding the node’s
actual dimensions, so `%width%` and `%height%` in filename_prefix resolve to 0.
Update `_save_file3d_to_output` and its caller from `execute_save_3d_advanced`
to pass the real width/height values into `folder_paths.get_save_image_path`,
matching the pattern used by other Save* nodes so templated filenames use the
node inputs instead of defaults.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: d9338cc5-1901-4422-b813-4dcd2a719ee1
📒 Files selected for processing (1)
comfy_extras/nodes_save_3d.py
eea3502 to
78d9bfd
Compare
d17642f to
747d212
Compare
747d212 to
74f9907
Compare
f1d542e
Add Save3DAdvanced, SaveGaussianSplat, and SavePointCloud as the save-side counterparts to the advanced preview nodes (Preview 3D (Advanced), Preview Splat, Preview Point Cloud).
Each mirrors its preview node's input/output shape and display name, and saves the File3D to the output directory under filename_prefix (preserving the original format), then emits PreviewUI3DAdvanced for the viewport.
FE change - Comfy-Org/ComfyUI_frontend#13330
Screenshot

Save 3D (Advanced)
Save Splat
