docs: clarify update/lifecycle entry points via help text (BE-3001)#520
docs: clarify update/lifecycle entry points via help text (BE-3001)#520mattmillerai wants to merge 2 commits into
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 55 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @mattmillerai.
✅ No high-signal findings.
Panel: 6/8 reviewers contributed findings.
Reviewers that did not contribute: kimi-k2.5:adversarial (empty), kimi-k2.5:edge-case (empty)
|
The failing |
|
🤖 The reviews loop filed Linear follow-up ticket(s) for review thread(s) deferred as out of scope for this PR:
|
…E-3001)
Rich parses square brackets in Typer `help=` as console markup, so
`[all|comfy|cli]` was silently stripped from the rendered help. With this
PR's appended cross-reference the panel read:
Update ComfyUI Environment . To update custom nodes, use `comfy node update`.
— the target list gone and a stray " ." left behind. Escaping the opening
bracket makes it render literally:
Update ComfyUI Environment [all|comfy|cli]. To update custom nodes, use
`comfy node update`.
Self-review finding; verified by rendering `comfy update --help`.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
🤖 Self-review pass — one real finding, fixed in d97d9d4. Rich was eating this PR's own help text. Square brackets in a Typer …target list gone, stray Verified by rendering the real Also verified the negative claims are accurate, since two of them deny a capability:
Deferred to a follow-up: 16 other Status: |
|
🤖 The reviews loop filed Linear follow-up ticket(s) for review thread(s) deferred as out of scope for this PR:
|
|
ℹ️ Reviews-loop triage pass — no code change made; both red checks are pre-existing infra, not this PR. This PR is help-text-only (4 Typer
Confirmed red on #541, #543, #544, #545 as well. Deferred to a follow-up rather than fixed here — it is a cross-cutting dependency fix in an unrelated module, and folding it into a docs PR would bury it (and race the other open PRs hitting the same check).
Neither failure is attributable to this diff. Ready to merge once the |
|
✏️ Correction to my previous comment: the So the triage for #520 stands unchanged, with both red checks tracked elsewhere and neither caused by this diff:
Nothing actionable remains on this PR: no code change, no new ticket. |
ELI-5
comfyhas four commands that sound like they might all "update" things, and it's confusing which does what:comfy update— updates ComfyUI itself (or comfy-cli).comfy node update— updates custom nodes.comfy manager— turns ComfyUI-Manager on/off and configures it. Not an updater.comfy standalone— downloads a standalone Python interpreter bundle. Not an updater.This PR is help-text only — no renames, no aliases, no behavior change. It adds cross-references so
--helpsteers you to the right command, and relabels the two that were mislabeled as "update-ish".What changed
comfy updateUpdate ComfyUI Environment [all|comfy|cli]To update custom nodes, usecomfy node update.comfy node updateUpdate custom nodes or ComfyUITo update ComfyUI itself or the CLI, usecomfy update.comfy managerManage ComfyUI-Manager.Enable/disable and configure ComfyUI-Manager (lifecycle, not updates).comfy standaloneDownload a standalone Python interpreter…This bundles an interpreter; it does not update ComfyUI or custom nodes.Notes / judgment calls
node updatekept its "or ComfyUI" wording (appended, not replaced).comfy node update alldispatches the same CM-CLIupdate allcall thatcomfy update alluses, so "or ComfyUI" is factually accurate — removing it would be a regression. Followed the ticket's "append" instruction rather than rewording.comfy discoverself-describing surface builds its command tree from the live Typerappat runtime (build_help_json), and its tests validate against JSON schemas, not exact help strings — so the new text flows through automatically. Full unit suite is green (2471 passed, 13 skipped).comfy update,comfy node update) exist and are explicitly cross-referenced.Testing
ruff format+ruff checkclean on both touched files.comfy update|node update|manager|standalone --helprender the new strings correctly.pytest tests/comfy_cli→ 2471 passed, 13 skipped.