[fix] Prevent JavaScript syntax errors in sync workflow#41
Merged
christian-byrne merged 1 commit intomainfrom Jun 2, 2025
Merged
[fix] Prevent JavaScript syntax errors in sync workflow#41christian-byrne merged 1 commit intomainfrom
christian-byrne merged 1 commit intomainfrom
Conversation
Uses environment variables instead of template literals to avoid conflicts with special characters in PR titles, RFC content, and other GitHub Actions expressions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes syntax errors in the RFC discussion sync workflow that occur when PR titles or RFC content contain special characters like brackets, quotes, or apostrophes.
Problem: The sync workflow was embedding GitHub Actions expressions directly in JavaScript template literals, causing syntax errors when content contained special characters.
Solution: Use environment variables to pass all dynamic content, avoiding template literal conflicts.
This enables the sync workflow to handle any RFC content safely, including edge cases like:
[feat] Add new featureGitHub's APITesting: After merge, the existing test PR should successfully sync discussion content on future commits.