Skip to content

fixed typo in generically depends on#198

Merged
cameronmore merged 1 commit into
masterfrom
179-typo-in-definition-of-generically_depends_on
Nov 16, 2023
Merged

fixed typo in generically depends on#198
cameronmore merged 1 commit into
masterfrom
179-typo-in-definition-of-generically_depends_on

Conversation

@cameronmore
Copy link
Copy Markdown
Contributor

Fixed a small typo

@mark-jensen @johnbeve

@cameronmore cameronmore linked an issue Nov 7, 2023 that may be closed by this pull request
@mark-jensen
Copy link
Copy Markdown

@cameronmore Unfortunately this PR won't be accepted. This is problem in BFO. We build merged all core using the BFO file.

@johnbeve The file I used was one you gave me for testing. Can you point us to where that lives? I can't find it in your fork. If recall correctly, it has been updated since you provided it to us. If the error is still there, we can make the fix.

@cameronmore
Copy link
Copy Markdown
Contributor Author

@mark-jensen Even if we fix the BFO file, can't we still fix this one since presumably this file will continue to exist on the repo, just like 1.3? So that when users, like myself locally, load this file it can have the fixed typo. This version of the file will live on as a relic once the 1.5 is pushed as a new All-Merged, right?

@mark-jensen
Copy link
Copy Markdown

@cameronmore My mistake, this error exists in RO. Because we use an old version of RO, my guess is that they already caught this typo. But you may want to follow up there and confirm it's not in the current version.

@cameronmore cameronmore merged commit 86eea9e into master Nov 16, 2023
@johnbeve johnbeve deleted the 179-typo-in-definition-of-generically_depends_on branch August 18, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo in definition of 'generically_depends_on'

2 participants