fixed typo in generically depends on#198
Conversation
|
@cameronmore Unfortunately this PR won't be accepted. This is problem in BFO. We build merged all core using the BFO file. @johnbeve The file I used was one you gave me for testing. Can you point us to where that lives? I can't find it in your fork. If recall correctly, it has been updated since you provided it to us. If the error is still there, we can make the fix. |
|
@mark-jensen Even if we fix the BFO file, can't we still fix this one since presumably this file will continue to exist on the repo, just like 1.3? So that when users, like myself locally, load this file it can have the fixed typo. This version of the file will live on as a relic once the 1.5 is pushed as a new All-Merged, right? |
|
@cameronmore My mistake, this error exists in RO. Because we use an old version of RO, my guess is that they already caught this typo. But you may want to follow up there and confirm it's not in the current version. |
Fixed a small typo
@mark-jensen @johnbeve