Skip to content

asserted 'has value' data property and added definitions#331

Merged
neilotte merged 2 commits into
CommonCoreOntology:developfrom
cameronmore:data-property-tidying
Aug 18, 2024
Merged

asserted 'has value' data property and added definitions#331
neilotte merged 2 commits into
CommonCoreOntology:developfrom
cameronmore:data-property-tidying

Conversation

@cameronmore
Copy link
Copy Markdown
Contributor

Implemented a change discussed in #188 and added definitions for data properties

@cameronmore cameronmore linked an issue Aug 5, 2024 that may be closed by this pull request
@alanruttenberg
Copy link
Copy Markdown
Contributor

'has value' means exactly the same thing as topDataProperty. All data properties have a range that is a data value, i.e an rdfs:Literal.

Also note the relation to the value specification proposal.

@neilotte
Copy link
Copy Markdown
Contributor

neilotte commented Aug 6, 2024

@cameronmore Per @alanruttenberg 's comment, seems cco:has_value should be deprecated. Concur?

@cameronmore
Copy link
Copy Markdown
Contributor Author

I just want to tag @mark-jensen since he originally discussed this in #188

@swartik
Copy link
Copy Markdown
Contributor

swartik commented Aug 6, 2024

@neilotte cco:has_value is a new data property so it needn't be deprecated.

I do not think we are ready to introduce cco:has_value. Per issue #188, we still have not resolved its domain. The current set of CCO data properties all use IBE, which is not universally accepted as preferrable. As @alanruttenberg stated elsewhere (too many issues and discussions for me to find it quickly), we probably will have to delay this until 1.7.

@cameronmore
Copy link
Copy Markdown
Contributor Author

I agree, introduction of new datatypes should be coordinated with @alanruttenberg 's value specification proposal and its design pattern. I will remove reference to it, and I will change the range of cco:has_text_value to an xsd:string or rdf:langString which solves the original reasoning error.

Related, this is an interesting proposal for the creation of xsd:InternationalizedString

@neilotte
Copy link
Copy Markdown
Contributor

neilotte commented Aug 7, 2024

@cameronmore In that case, can we close this PR?

@cameronmore
Copy link
Copy Markdown
Contributor Author

cameronmore commented Aug 7, 2024

@neilotte I still changed the range of has_text_value which addresses the original issue raised in #188 by @swartik as well as added nominal definitions

Copy link
Copy Markdown
Contributor

@neilotte neilotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @cameronmore. Approving.

@neilotte
Copy link
Copy Markdown
Contributor

neilotte commented Aug 8, 2024

@mark-jensen -- Can you also review this? @cameronmore requested your review as well.

@neilotte neilotte merged commit f09a938 into CommonCoreOntology:develop Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Range of has_text_value is too narrow

4 participants