259 use of instance of in has member of located in definition and other ero definitions#350
Merged
Conversation
Contributor
Author
This was
linked to
issues
Aug 12, 2024
Contributor
|
The change from 'has member of located in' to 'has all members of located in' definitely seems good. However, while you made that change in the label, you didn't do so in the definition. |
Contributor
Author
|
@gregfowlerphd myintent was to make the label more accurately reflect the definition, rather than change the semantics of the term, and then to introduce the other relation whose label and definition makes it distinct from the already existing one. This also avoids a case of deprecation. |
Contributor
|
Right. My point (which maybe I expressed poorly) is that the definition for the object property cco: has_some_member_of_located_in starts with 'x has member of located in y iff...'. Notice the lack of the word 'some' here. |
Contributor
Author
|
@gregfowlerphd ah I see, thanks! |
neilotte
approved these changes
Aug 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.