Skip to content

improved definitions per #358#433

Merged
neilotte merged 2 commits into
CommonCoreOntology:developfrom
gregfowlerphd:improved-definitions-per-#358
Sep 1, 2024
Merged

improved definitions per #358#433
neilotte merged 2 commits into
CommonCoreOntology:developfrom
gregfowlerphd:improved-definitions-per-#358

Conversation

@gregfowlerphd
Copy link
Copy Markdown
Contributor

Fixes #358

@gregfowlerphd
Copy link
Copy Markdown
Contributor Author

@johnbeve: Done

@cameronmore
Copy link
Copy Markdown
Contributor

@gregfowlerphd The repo restructuring might have been the cause of the conflicts on the other branches, but these still look like they are able to merge easily.

@gregfowlerphd
Copy link
Copy Markdown
Contributor Author

@cameronmore: Thanks, Cameron. :)

Copy link
Copy Markdown
Contributor

@neilotte neilotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eye @gregfowlerphd

@neilotte neilotte merged commit 6d98eb4 into CommonCoreOntology:develop Sep 1, 2024
@gregfowlerphd
Copy link
Copy Markdown
Contributor Author

@neilotte: Thanks, Neil. :) I admit I'm still not entirely sold on using the "instance of" locution in these definitions but not in class definitions, but since that seemed to be the consensus choice (such as it were), I thought it best not to rock the boat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use of 'instance of' in definitions for four object properties

3 participants