improved definitions per #358#433
Merged
neilotte merged 2 commits intoSep 1, 2024
Merged
Conversation
Contributor
Author
|
@johnbeve: Done |
Contributor
|
@gregfowlerphd The repo restructuring might have been the cause of the conflicts on the other branches, but these still look like they are able to merge easily. |
Contributor
Author
|
@cameronmore: Thanks, Cameron. :) |
neilotte
approved these changes
Sep 1, 2024
Contributor
neilotte
left a comment
There was a problem hiding this comment.
Good eye @gregfowlerphd
Contributor
Author
|
@neilotte: Thanks, Neil. :) I admit I'm still not entirely sold on using the "instance of" locution in these definitions but not in class definitions, but since that seemed to be the consensus choice (such as it were), I thought it best not to rock the boat. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #358