repair cco superclass query#525
Merged
Merged
Conversation
neilotte
reviewed
Nov 2, 2024
Contributor
neilotte
left a comment
neilotte
left a comment
There was a problem hiding this comment.
@johnbeve Let's look at this together and discuss a test plan for these queries generally. In this case, I checked the original query in GraphDB and tried different configuration settings and regardless of the setting config I returned no false positives as expected.
Contributor
Author
|
@neilotte Look at line 42 of the "Build and Test Ontology Release" step: https://github.com/CommonCoreOntology/CommonCoreOntologies/actions/runs/11632170520/job/32394719773 |
neilotte
approved these changes
Nov 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Query requiring CCO classes fall under BFO was returning >100 false positives. Tried to test in protege, but 'contains' not supported. Replaced 'contains' with 'regex' and tested. No false positives in protege.
Let's see if false positives are generated in the build after this update.