Skip to content

Change frameworks. #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rahefrends wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Change frameworks. #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c62e5bc
Change frameworks.
rahefrends Feb 10, 2025
cdca15e
Test only with framework and net8.0
rahefrends Feb 24, 2025
09a7c00
Remove framework test
rahefrends Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/BuildAndTestOnEveryPush.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@ jobs:
run: dotnet pack --configuration Release --include-source

- name: Push NuGet package to the testfeed
run: dotnet nuget push Frends.Community.PostFile\bin\Release\Frends.Community.PostFile.*.nupkg --api-key ${{ secrets.COMMUNITY_FEED_API_KEY }} --source https://www.myget.org/F/frends-community-test/api/v2/package --symbol-source https://www.myget.org/F/frends-community-test/symbols/api/v2/package
run: dotnet nuget push Frends.Community.PostFile\bin\Release\Frends.Community.PostFile.*.nupkg --api-key ${{ secrets.COMMUNITY_FEED_API_KEY }} --source https://www.myget.org/F/frends-community-test/api/v2/package
2 changes: 1 addition & 1 deletion .github/workflows/PackAndPushAfterMerge.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
run: dotnet pack --configuration Release --include-source

- name: Push NuGet package to the (prod) feed
run: dotnet nuget push Frends.Community.PostFile\bin\Release\Frends.Community.PostFile.*.nupkg --api-key ${{ secrets.COMMUNITY_FEED_API_KEY }} --source https://www.myget.org/F/frends-community/api/v2/package --symbol-source https://www.myget.org/F/frends-community/symbols/api/v2/package
run: dotnet nuget push Frends.Community.PostFile\bin\Release\Frends.Community.PostFile.*.nupkg --api-key ${{ secrets.COMMUNITY_FEED_API_KEY }} --source https://www.myget.org/F/frends-community/api/v2/package

- name: Create Release
id: create_release
Expand Down
3 changes: 2 additions & 1 deletion Frends.Community.PostFile.Tests/Frends.Community.PostFile.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public async Task RequestShouldSetEncodingWithContentTypeCharsetIgnoringCase()

_stubHttp.Stub(x => x.Post("/endpoint"))
.AsContentType($"text/plain; charset={codePageName}")
.Return("foo ���")
.Return("foo ���")
.OK();

var contentType = new Header { Name = "cONTENT-tYpE", Value = expectedContentType };
Expand All @@ -48,6 +48,7 @@ public async Task RequestShouldSetEncodingWithContentTypeCharsetIgnoringCase()
//Casing should not affect setting header.
Assert.That(requestContentType, Is.EqualTo(expectedContentType));
Assert.That(requestBodyByteArray, Is.EqualTo(utf8ByteArray));
_stubHttp.Dispose();
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion Frends.Community.PostFile.Tests/Frends.Community.PostFile.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net471</TargetFramework>
<TargetFrameworks>netstandard2.0;net8.0</TargetFrameworks>

<IsPackable>false</IsPackable>
</PropertyGroup>
Expand Down
4 changes: 2 additions & 2 deletions Frends.Community.PostFile/Frends.Community.PostFile.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netstandard2.0;net471</TargetFrameworks>
<TargetFrameworks>netstandard2.0;net471;net6.0;net8.0</TargetFrameworks>
<authors>HiQ Finland</authors>
<copyright>HiQ Finland</copyright>
<PackageLicenseExpression>MIT</PackageLicenseExpression>
<PackageProjectUrl>https://github.com/CommunityHiQ/Frends.Community.PostFile</PackageProjectUrl>
<IncludeSource>true</IncludeSource>
<PackageTags>Frends</PackageTags>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<Version>1.0.1</Version>
<Version>1.0.2</Version>
</PropertyGroup>

<ItemGroup>
Expand Down