feat: create AzureStorageExplorer hosting integration#1090
Conversation
|
@aaronpowell I am curious what you think of the public API design before writing some tests. |
aaronpowell
left a comment
There was a problem hiding this comment.
For consistency sake, I think it makes more sense of the public API to be:
builder.AddAzureStorage("storage")
.RunAsEumulator()
.WithAzureStorageExplorer();This is then consistent with the other web UI tools for inspecting storage resources (pgadmin, dbgate, etc.), it also removes the ambiguity that you might see if you were to do this on the current API:
var azureStorageExplorer = builder
.AddAzureStorageExplorer("explorer")
.WithAzurite()
.WithBlobs(blobs)
.WithQueues(queue);
That is reasonably good. However, the storage.AddBlobs("blobs").WithAzureStorageExplorer(); |
I didn't realise that. Yes, then it makes sense to have it off the blob/queue/etc. resource instead. Looking at the storage explorer, it seems like it's not a singleton resource either, so if you had blobs + queues it would make sense to have multiple explorers right? |
AFAIK I know, yes, an explorer can only a single Azure storage/emulator resource. I suppose this is a feature that can be worked on in the future for this project. Best option would be to get the full connection string from the Azure storage resource but until then, we can only work with an instance per blobs/queues/tables resource unfortunateyl. |
6c2d618 to
c9bbc28
Compare
a5c8f7e to
3ac3443
Compare
aaronpowell
left a comment
There was a problem hiding this comment.
Minor nit on the code and looks like there's a test failing still
3ac3443 to
3fe264f
Compare
|
I am not sure what is the issue. The tests work on my machine. |
aaronpowell
left a comment
There was a problem hiding this comment.
I think it fails on Windows because it needs docker
Given microsoft/aspire#3778 and the need for an Azure Storage Explorer, I create a new package called
CommunityToolkit.Aspire.Hosting.Azure.Extensions.This is a 3rd party project that is constantly maintained (last commit last month), has 141 stars on GitHub and 2M+ downloads on Docker.
PR Checklist
Other information