You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Follow-up to #509 (Phase 2 of the samples CI rollout). This covers the Windows-only build heads that require a windows-latest runner and were explicitly deferred out of the Phase 1 build-samples.yml workflow.
Additional finding (discovered while implementing Phase 1, see #509)
The Phase 1 issue's inventory table listed samples/todoapp-tutorial/todoapp.sln as a plain net10.0 sample buildable on ubuntu-latest. That's inaccurate: ClientApp in that solution is a WPF app targeting net10.0-windows. Phase 1 (build-samples-todoapp-tutorial.yml) only builds ServerApp.csproj on ubuntu-latest; ClientApp needs to be picked up here, alongside the other WPF/WinUI3/MAUI-Windows heads.
Summary
Follow-up to #509 (Phase 2 of the samples CI rollout). This covers the Windows-only build heads that require a
windows-latestrunner and were explicitly deferred out of the Phase 1build-samples.ymlworkflow.Scope
Add Windows-runner coverage for:
samples/todoapp/TodoApp.WinUI3/TodoApp.WinUI3.csprojnet10.0-windows10.0.19041.0samples/todoapp/TodoApp.WPF/TodoApp.WPF.csprojnet10.0-windowssamples/todoapp/TodoApp.MAUI/TodoApp.MAUI.csprojnet10.0-windows10.0.19041.0), conditionally added when building on Windows —mauiworkload requiredsamples/todoapp-tutorial/ClientApp/ClientApp.csprojnet10.0-windows(WPF)Additional finding (discovered while implementing Phase 1, see #509)
The Phase 1 issue's inventory table listed
samples/todoapp-tutorial/todoapp.slnas a plainnet10.0sample buildable onubuntu-latest. That's inaccurate:ClientAppin that solution is a WPF app targetingnet10.0-windows. Phase 1 (build-samples-todoapp-tutorial.yml) only buildsServerApp.csprojonubuntu-latest;ClientAppneeds to be picked up here, alongside the other WPF/WinUI3/MAUI-Windows heads.Suggested approach
windows-latestjob (or reusable per-sample workflow, following the pattern established in Add CI workflow to build all /samples projects on PR #509) for each of the four projects above.mauiworkload before buildingTodoApp.MAUI.csproj.dotnet restore+dotnet build), consistent with Phase 1.Related