Fixed building in codespaces #380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t and fallback logic to new file.
Arlodotexe
added
Uno
michael-hawker
approved these changes
Mar 3, 2023
Member
michael-hawker
left a comment
michael-hawker
left a comment
There was a problem hiding this comment.
Tested in codespaces, works great! 🎉🎉🎉
Member
|
@Arlodotexe does this fix #190 as well now then too? |
Member
Author
That's a bit of a different issue. |
Martin1994
pushed a commit
to Martin1994/Labs-Windows
that referenced
this pull request
Sep 2, 2023
* Fixed an issue where labs wouldn't build in codespaces * Fixed MultiTarget system in codespaces. Moved retrieval of multitarget and fallback logic to new file. * Fixed building locally * Added lost changes caused by git suppression * Removed vscode launch generation from sln gen * Removed unused $MultiTarget param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #360 and #369, we organized and consolidated our projects heads, and renamed the folder which components are contained in.
While these were tested to work locally, Codespaces was not reconfigured to use the new paths.
This PR
Pathenvironment variable would cause the build to fail (e.g., on linux)