Skip to content

Tidy up the masked text behavior handling of text changed #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheCodeTraveler merged 3 commits into from
Jun 11, 2024
Merged

Tidy up the masked text behavior handling of text changed #1925

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84c2507
Queue up the Text update when running on Android
bijington Jun 9, 2024
f472bb5
Provide a more consistent approach across all platforms
bijington Jun 11, 2024
7b572f5
Merge branch 'main' into feature/sl-460-masked-text
bijington Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions src/CommunityToolkit.Maui/Behaviors/MaskedBehavior.shared.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,14 +104,10 @@ static async void OnUnmaskedCharacterPropertyChanged(BindableObject bindable, ob

Task OnTextPropertyChanged(CancellationToken token)
{
#if ANDROID
// Android does not play well when we update the Text inside the TextChanged event. Therefore if we dispatch
// the mechanism of updating the Text property it solves the issue of the caret position being updated incorrectly.
Application.Current?.Dispatcher.Dispatch(async () => await ApplyMask(View?.Text, token));
return Task.CompletedTask;
#else
return ApplyMask(View?.Text, token);
#endif
// Android does not play well when we update the Text inside the TextChanged event.
// Therefore if we dispatch the mechanism of updating the Text property it solves the issue of the caret position being updated incorrectly.
// https://github.com/CommunityToolkit/Maui/issues/460
return View?.Dispatcher.DispatchAsync(() => ApplyMask(View?.Text, token)) ?? Task.CompletedTask;
}

void SetMaskPositions(in string? mask)
Expand Down