Fix Android Service not being disabled when set

[ne0rrmatrix]

Android MediaSessionService was not being disabled when setting IsAndroidForegroundServiceEnabled to false. This fixes it and removes setting the default value that was being set erroneously. It should never have been set. This is why the analyzer was created to verify that it was set and cause a build error message otherwise.

Description of Change

Refactored MediaElementOptions to remove the default true value for IsAndroidForegroundServiceEnabled, making it default to false. Removed the UpdateIsAndroidForegroundServiceEnabledWithUseMauiCommunityToolkitMediaElementParameter method and now use SetIsAndroidForegroundServiceEnabled directly. Updated AppBuilderExtensions and unit tests to reflect these changes and ensure correct behavior with the simplified property logic.

Linked Issues

• Fixes [BUG] isAndroidForegroundServiceEnabled set to false results in java.lang.SecurityException: Permission Denial #3103

PR Checklist

• Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
• Has tests (if omitted, state reason in description)
• Has samples (if omitted, state reason in description)
• Rebased on top of main at time of PR
• Changes adhere to coding standard
• Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

Please test and verify this works for more than just me :)

[Copilot]

Pull request overview

This PR fixes a critical bug where setting IsAndroidForegroundServiceEnabled to false in MediaElement would still result in the Android Foreground Service being enabled. The root cause was twofold: the property defaulted to true, and the method that updated it used a logical OR assignment (|=) that prevented it from ever being set to false.

Changes:

• Removed erroneous default value (= true) from IsAndroidForegroundServiceEnabled, allowing it to default to false
• Removed UpdateIsAndroidForegroundServiceEnabledWithUseMauiCommunityToolkitMediaElementParameter method that used |= operator
• Changed SetIsAndroidForegroundServiceEnabled visibility from public to internal to prevent external misconfiguration
• Simplified AppBuilderExtensions to call SetIsAndroidForegroundServiceEnabled directly instead of using the removed method
• Updated unit tests to reflect the new behavior

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
MediaElementOptions.shared.cs	Removed default true initialization and the problematic UpdateIsAndroidForegroundServiceEnabledWithUseMauiCommunityToolkitMediaElementParameter method; changed SetIsAndroidForegroundServiceEnabled to internal
AppBuilderExtensions.shared.cs	Simplified to call SetIsAndroidForegroundServiceEnabled directly with the parameter value
MediaElementOptionsTests.cs	Updated tests to verify the corrected behavior, removed tests for the deleted method

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 11 comments.

Comments suppressed due to low confidence (1)

src/CommunityToolkit.Maui.UnitTests/Extensions/AppBuilderExtensionsTests.cs:269

• Test logic appears incorrect. The test calls SetIsAndroidForegroundServiceEnabled(false) on line 266, but then asserts that IsAndroidForegroundServiceEnabled should be true on line 269. Based on the PR description stating that SetIsAndroidForegroundServiceEnabled should directly set the value, this assertion should be false, or the method call on line 266 should be SetIsAndroidForegroundServiceEnabled(true) if the intention is to verify that the options callback overrides the parameter value.