Another fix for the Converters ProjectReference logic#119
Merged
Conversation
We need to add the Converters when running in Single Component mode, as it's only included in the all-up sample app locally (when source defined). We also need to exclude if we're building the Converters project itself. However, if a component itself relies on the converters and we try and to build on Linux we'll hit the original issue. Workaround for now there is to build all-up sample app instead... Tested locally that the Converters and another component both could be built now.
michael-hawker
added
bug 🐛
Arlodotexe
approved these changes
Aug 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to add the Converters when running in Single Component mode, as it's only included in the all-up sample app locally (when source defined).
We also need to exclude if we're building the Converters project itself.
However, if a component itself relies on the converters and we try and to build on Linux we'll hit the original issue. Workaround for now there is to build all-up sample app instead...
Tested locally that the Converters and another component both could be built now.