Skip to content

Clip inner content from AttachedCardShadow using CompositionMaskBrush #4404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michael-hawker merged 14 commits into from
May 11, 2022
Merged

Clip inner content from AttachedCardShadow using CompositionMaskBrush #4404

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
5704ce1
Additional null checks
chris-blackman Oct 22, 2021
fded2ed
Add InnerContentClipMode
chris-blackman Oct 27, 2021
136436f
Remove unused code. Add InnerContentClipMode.None.
chris-blackman Oct 27, 2021
aa9a7ae
Fix NullReferenceException
chris-blackman Nov 5, 2021
7c1da95
Add InnerContentClipMode to sample
chris-blackman Nov 5, 2021
095c315
Set CompositionGeometricClip as the default clipping mode
chris-blackman Nov 15, 2021
d90b89a
Don't inherit from AttachedCardShadowBase
chris-blackman Nov 24, 2021
2c870ee
Rearrange elements
chris-blackman Nov 24, 2021
169e296
Add comment.
chris-blackman Nov 24, 2021
0809907
Add header
chris-blackman Nov 30, 2021
d2c13d0
Update AttachedCardShadow.cs
chris-blackman Apr 6, 2022
b6cf5c1
Update AttachedCardShadow.cs
chris-blackman Apr 6, 2022
555d6e9
Add comments to AttachedCardShadow
chris-blackman May 9, 2022
65e350b
Use "is not null" instead of "!= null" in AttachedShadowElementContext
chris-blackman May 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix NullReferenceException
  • Loading branch information
@chris-blackman
chris-blackman committed Apr 6, 2022
commit aa9a7aebe8c86e9043ce08730aa5d7e4161969f0
4 changes: 2 additions & 2 deletions Microsoft.Toolkit.Uwp.UI/Shadows/AttachedShadowElementContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ public T GetResource<T>(string key)
/// <returns>The resource that was removed, if any</returns>
public T RemoveResource<T>(string key)
{
if (_resources.TryGetValue(key, out var objResource))
if (_resources != null && _resources.TryGetValue(key, out var objResource))
{
_resources.Remove(key);
if (objResource is T resource)
Expand All @@ -255,7 +255,7 @@ public T RemoveResource<T>(string key)
public T RemoveAndDisposeResource<T>(string key)
where T : IDisposable
{
if (_resources.TryGetValue(key, out var objResource))
if (_resources != null && _resources.TryGetValue(key, out var objResource))
{
_resources.Remove(key);
if (objResource is T resource)
Expand Down