Skip to content

Fixed narrator not announcing RangeSelector values / changes #4442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Arlodotexe wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed narrator not announcing RangeSelector values / changes #4442

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1784fc8
Fixed issue where narrator wasn't announcing progress changes for Ran…
Arlodotexe Dec 29, 2021
b061bb6
Removed two-way binding on RangeThumb to prevent intereference
Arlodotexe Dec 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Removed two-way binding on RangeThumb to prevent intereference
  • Loading branch information
@Arlodotexe
Arlodotexe committed Dec 30, 2021
commit b061bb6b5c4d91d81b14e4feddf56a28780cf2b1
12 changes: 6 additions & 6 deletions Microsoft.Toolkit.Uwp.UI.Controls.Input/RangeSelector/RangeSelector.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,20 +150,20 @@
<controls:RangeThumb x:Name="MinThumb"
AutomationProperties.Name="Min thumb"
IsTabStop="True"
Maximum="{Binding Maximum, Mode=TwoWay, RelativeSource={RelativeSource Mode=TemplatedParent}}"
Minimum="{Binding Minimum, Mode=TwoWay, RelativeSource={RelativeSource Mode=TemplatedParent}}"
Maximum="{Binding Maximum, RelativeSource={RelativeSource Mode=TemplatedParent}}"
Minimum="{Binding Minimum, RelativeSource={RelativeSource Mode=TemplatedParent}}"
Style="{StaticResource RangeThumbStyle}"
TabIndex="0"
Value="{Binding RangeStart, Mode=TwoWay, RelativeSource={RelativeSource Mode=TemplatedParent}}" />
Value="{Binding RangeStart, RelativeSource={RelativeSource Mode=TemplatedParent}}" />

<controls:RangeThumb x:Name="MaxThumb"
AutomationProperties.Name="Max thumb"
IsTabStop="True"
Maximum="{Binding Maximum, Mode=TwoWay, RelativeSource={RelativeSource Mode=TemplatedParent}}"
Minimum="{Binding Minimum, Mode=TwoWay, RelativeSource={RelativeSource Mode=TemplatedParent}}"
Maximum="{Binding Maximum, RelativeSource={RelativeSource Mode=TemplatedParent}}"
Minimum="{Binding Minimum, RelativeSource={RelativeSource Mode=TemplatedParent}}"
Style="{StaticResource RangeThumbStyle}"
TabIndex="1"
Value="{Binding RangeEnd, Mode=TwoWay, RelativeSource={RelativeSource Mode=TemplatedParent}}" />
Value="{Binding RangeEnd, RelativeSource={RelativeSource Mode=TemplatedParent}}" />
</Canvas>
</Grid>
</ControlTemplate>
Expand Down