Reference validation in OVAL document object#11235
Merged
jan-cerny merged 3 commits intoNov 2, 2023
Merged
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
Honny1
added
enhancement
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
Code Climate has analyzed commit 0a57827 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.5%. View more on Code Climate. |
jan-cerny
changed the title
jan-cerny
approved these changes
Nov 2, 2023
Collaborator
jan-cerny
left a comment
jan-cerny
left a comment
There was a problem hiding this comment.
I confirm the unit test passes for me. Thanks for this improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR creates a method that checks if all component references are present in an OVAL document. This PR also changes the product argument of the
load_shorthandmethod in theOVALDocumentclass to an optional argument.Rationale:
This PR is part of the modifications to the OVAL object model for integration into the
combine_ovals.pyscript.Review Hints:
You can use the test suite run with
toxto test the changes.