New Rules Must Have a prodtype

[Mab879]

Description:

This adds a test that checks

• New rules must a have prodtype
• Existing rules with a prodtype must continue to have it

Rationale:

This will be helpful in the future when we move prodtypes.

Review Hints:

Remove a prodtype rule and watch the new test fail.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[github-actions]

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment

Oracle Linux 8 Environment

[jan-cerny]

It works as expected. I have removed prodtype from 2 random rules and it detected it and failed.

1/2 Test  #9: test-rule-dir-json ....................   Passed   15.32 sec
test 39
    Start 39: test-no-new-global-applicable-rules

39: Test command: /usr/bin/env "PYTHONPATH=/home/jcerny/work/git/scap-security-guide" "/usr/bin/python3" "/home/jcerny/work/git/scap-security-guide/utils/no_new_global_applicable_rules.py" "--root" "/home/jcerny/work/git/scap-security-guide" "--json" "/home/jcerny/work/git/scap-security-guide/build/rule_dirs.json"
39: Working Directory: /home/jcerny/work/git/scap-security-guide/build/tests
39: Test timeout computed to be: 10000000
39: Rule service_timesyncd_root_distance_configured doesn't have a prodtype and it is expected to. You must add one.
39: Rule service_timesyncd_configured doesn't have a prodtype and it is expected to. You must add one.
2/2 Test #39: test-no-new-global-applicable-rules ...***Failed    0.26 sec

The following tests passed:
	test-rule-dir-json

50% tests passed, 1 tests failed out of 2

Label Time Summary:
quick    =  15.32 sec*proc (1 test)

Total Test time (real) =  15.59 sec

The following tests FAILED:
	 39 - test-no-new-global-applicable-rules (Failed)
Errors while running CTest

[Mab879]

/packit retest-failed

[jan-cerny]

Code Climate wants you to simplify this function

[qlty-cloud-legacy]

Code Climate has analyzed commit de666d5 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.8%.

View more on Code Climate.

[jan-cerny]

jcerny@fedora ~/work/git/scap-security-guide/build (pr/11252) $ ctest --output-on-failure -R test-no-new-global-applicable-rules
Test project /home/jcerny/work/git/scap-security-guide/build
    Start  6: test-rule-dir-json
1/2 Test  #6: test-rule-dir-json ....................   Passed   15.69 sec
    Start 25: test-no-new-global-applicable-rules
2/2 Test #25: test-no-new-global-applicable-rules ...***Failed    0.27 sec
Rule service_timesyncd_configured doesn't have a prodtype and it is expected to. You must add one.


50% tests passed, 1 tests failed out of 2

Label Time Summary:
quick    =  15.69 sec*proc (1 test)

Total Test time (real) =  15.97 sec

The following tests FAILED:
	 25 - test-no-new-global-applicable-rules (Failed)
Errors while running CTest
jcerny@fedora ~/work/git/scap-security-guide/build (pr/11252) $ 

Thanks for this great improvement!