Add alternatives to mandatory keys#11268
Conversation
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
jan-cerny
left a comment
jan-cerny
left a comment
There was a problem hiding this comment.
I tried this and it works for me as expected 👍
| msg = "Profile {0} unselects all groups.".format(self.id_) | ||
| msg = ("Profile {0} unselects all groups. " | ||
| "Check whether it selects any rule or extends any profile." | ||
| .format(self.id_)) |
There was a problem hiding this comment.
Thanks for the review, should be fixed now.
yuumasato
force-pushed
the
allow_extends_in_place_of_selections
branch
from
cd8b25b to
58eea27
Compare
| @@ -55,6 +55,10 @@ class Profile(XCCDFEntity, SelectionHandler): | |||
| "selections", | |||
There was a problem hiding this comment.
@jan-cerny Another approach would be to remove selections from MANDATORY_KEYS, I don't think this would open gaps that could lead to problems. But the ALTERNATIVE_KEYS seem to guard and lead better to what is expected.
Don't require profiles to have 'selections' if they have an 'extends'. This allows a profile to just extend a profile without having to add any selection. Making it possible to have non-versioned profiles to extend versioned profiles.
yuumasato
force-pushed
the
allow_extends_in_place_of_selections
branch
from
58eea27 to
521a4dc
Compare
|
Code Climate has analyzed commit 521a4dc and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 37.5% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.8%. View more on Code Climate. |
3 participants
Description:
selectionsif they have anextends.Rationale:
Add profile aliases for OpenShift versioned profiles #11241
Review Hints:
extendsto any profile and remove the wholeselectionskey.