Skip to content

Add ubuntu 20.04 to audit_rules_kernel_module_loading_delete tests#11274

Merged
dodys merged 2 commits into
ComplianceAsCode:masterfrom
mpurg:stig_ubu-20-010181_testfix
Nov 15, 2023
Merged

Add ubuntu 20.04 to audit_rules_kernel_module_loading_delete tests#11274
dodys merged 2 commits into
ComplianceAsCode:masterfrom
mpurg:stig_ubu-20-010181_testfix

Conversation

@mpurg
Copy link
Copy Markdown
Contributor

@mpurg mpurg commented Nov 14, 2023

Description:

@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label Nov 14, 2023
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Nov 14, 2023

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 14, 2023

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

dodys
dodys requested changes Nov 14, 2023
View reviewed changes
Comment thread ...el_module_loading/audit_rules_kernel_module_loading_delete/tests/missing_auid_filter.fail.sh Outdated
@@ -1,5 +1,5 @@
#!/bin/bash
# platform = Oracle Linux 7,Oracle Linux 8,Red Hat Enterprise Linux 8
# platform = Oracle Linux 7,Oracle Linux 8,Red Hat Enterprise Linux 8,Ubuntu 20.04
Copy link
Copy Markdown
Contributor

@dodys dodys Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multi_platform_ubuntu

@mpurg mpurg requested a review from dodys November 14, 2023 14:19
@qlty-cloud-legacy
Copy link
Copy Markdown

qlty-cloud-legacy Bot commented Nov 14, 2023

Code Climate has analyzed commit 6f70a60 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.8%.

View more on Code Climate.

dodys
dodys approved these changes Nov 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks
tests failures not associated with this PR

@dodys dodys self-assigned this Nov 14, 2023
@dodys dodys added Ubuntu Ubuntu product related. ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Nov 14, 2023
@dodys dodys merged commit c6a7007 into ComplianceAsCode:master Nov 15, 2023
@Mab879 Mab879 added this to the 0.1.71 milestone Nov 15, 2023
@Mab879 Mab879 added Update Rule Issues or pull requests related to Rules updates. Test Suite Update in Test Suite. and removed Update Rule Issues or pull requests related to Rules updates. labels Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dodys dodys dodys approved these changes

Assignees

@dodys dodys

Labels

ok-to-test Used by openshift-ci bot. Test Suite Update in Test Suite. Ubuntu Ubuntu product related.

Projects

None yet

Milestone

0.1.71

Development

Successfully merging this pull request may close these issues.

3 participants

@mpurg @dodys @Mab879