Fix audit_rules_privileged_commands_kmod#11277
Merged
marcusburghardt merged 2 commits intoNov 17, 2023
Merged
Conversation
|
Start a new ephemeral environment with changes proposed in this pull request: rhel8 (from CTF) Environment (using Fedora as testing environment) Fedora Testing Environment Oracle Linux 8 Environment |
|
This datastream diff is auto generated by the check Click here to see the full diffNew data stream adds bash remediation for rule 'xccdf_org.ssgproject.content_rule_audit_rules_privileged_commands_kmod'.
New data stream adds ansible remediation for rule 'xccdf_org.ssgproject.content_rule_audit_rules_privileged_commands_kmod'. |
The keys used in the templated tests doesn't work with this rule.
Mab879
force-pushed
the
fix_audit_rules_privileged_commands_kmod
branch
from
3cfa31b to
2a52961
Compare
|
Code Climate has analyzed commit 2a52961 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.8%. View more on Code Climate. |
vojtapolasek
approved these changes
Nov 16, 2023
Collaborator
vojtapolasek
left a comment
vojtapolasek
left a comment
There was a problem hiding this comment.
Hello @Mab879 and thank you. Looks good. The failing test is not related to changes introduced in this rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Rationale: